Fixes Add github-handle for Adrian Inchauste in heart.md #6934

[mSharifHub]

Fixes #6934

What changes did you make?

• Added github-handle: to heart.md.

Why did you make the changes (we will use this info to test)?

• added github handle on heart.md file

Screenshots of Proposed Changes Of The Website (if any, please do not screenshot code changes)

No visual changes

Visuals before changes are applied

[github-actions]

Want to review this pull request? Take a look at this documentation for a step by step guide!

---

From your project repository, check out a new branch and test the changes.

git checkout -b mSharifHub-add-github-handle-AdrianInchauste-6934 gh-pages
git pull https://github.com/mSharifHub/hackforla-website.git add-github-handle-AdrianInchauste-6934

[dcotelessa]

Hi Mohamed!
Thanks for the PR.
A couple things:

• on the link in the PR description (Fixes Fixes Add github-handle for Adrian Inchauste in heart.md #6934 #6982), can we set the link to:
  Add github-handle for Adrian Inchauste in heart.md #6934 and change the number to the ticket number (Fixes Add github-handle for Adrian Inchauste in heart.md #6934). We don't have to link to the PR, since we are already here.
• Also, the github-handle should be blank as the task on the ticket describes. We will be adding the handle later.

Thank you.

[dcotelessa]

Check my comment.

Available: 9-5 T-F

[dcotelessa]

More feedback:

• Thank you for updating the file. Looks good.
• The description still isn't updated with ticket number.
• The screenshot information is still there.
  If you look at this latest PR, it might help you with the description:
  add github-handle variable for Gian Reyes Dionisio #6984 (review)
  Once we update that, I'll recheck.

Thanks for your contribution!

[ino-iosdev]

ETA: Eod

[ino-iosdev]

@mSharifHub

• Branch naming is good

Changes required:

1. Remove 6934 from the title (note how it becomes unclear since it stacks with your PR number 6982), replaceFixed Add to something like Added in title, this is to make is clear and readable as possible.

2. Properly link the issue following the auto-generated template guide, seems like you removed that line, it would look something like this:

3. Update your description on the changes made, I can see that you made changes in the file, but your description still has his name attached to github-handle:

](url)

4. Revise the Why did you make the changes answer: In general, it's a good practice to write details in your own words based on the request from the issue, see below from the original issue page

Check out this example of a similar issue for your reference #6917

5. No need to include screenshots unless your change will have any visual change to the website. Simply write "No visual change to the website" under the template guideline should suffice.

After making all these changes, don't forget to click on something like this on the top right of your page (see below) to request a review of your changes:

[dcotelessa]

We went through code during Tuesday zoom:

• PR Number is updated
• github-handle is added correctly.

Good work!

[ino-iosdev]

Thanks for making those changes @mSharifHub

Please address 1 and 4 in the previous change request, we are almost there!
Thank you!

[del9ra]

ETA: 06/13/2024
Availability: 1-5 PM monday-friday

[del9ra]

Hi @mSharifHub,
Nice job!

• The branching was done correctly
• No need to mention issue number in the PR title. Follow the example from the Contributing Guide: “Update Care Link in Credits Page”. Refer to this guide https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md
• Issue number was listed
• Not all pull requests will have significant changes to our website. Please do not do any screenshots of VSCode If you do not have the ability to notate changes, please remove this part "details>/<summary" and replace it with an explanation for no images like:
  ### Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
  No visual changes to the website.
  Please refer to the Contributing Guide: https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md
• Changes were made correctly in the code
• The PR request clearly states what was updated
• Please mark up “Action items” on the issue page Add github-handle for Adrian Inchauste in heart.md #6934
• Please provide a more detailed explanation of why the changes are being made
  Thank you for contributing to the website!

[ino-iosdev]

@mSharifHub

• Change 1 out of 5 hasn't been addressed, please reference the requested 5 changes in my previous comment.

• Change 4 out of 5 still needs revision, it's not about repeating the change you made, but rather why the change needs to be made, again, please reference the good example linked in my previous comment.

Thank you so much!

[Thinking-Panda]

@mSharifHub Please post an update on your progress in regards to the changes requested. If you need any help, please reach out on slack hfla-site channel.

[t-will-gillis]

@mSharifHub Please post an update on this PR and let us know when you plan to complete it. Thanks.

[t-will-gillis]

Hi @mSharifHub Unfortunately, there is a duplicate issue for this issue, so this PR and the original issue need to be closed. Sorry for the mixup.

Closing this because there was a duplicate issue for this ( #7045 )