[GH-15687] Extract string comparators from Duke library #15692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mn-mikke
requested review from
mmalohlava,
wendycwong,
valenad1 and
achraf-mer
achraf-mer
approved these changes
Aug 14, 2023
mmalohlava
approved these changes
Aug 14, 2023
There was a problem hiding this comment.
- Confirmed the license of original package as Apache V2: https://github.com/larsga/Duke/tree/master
Mohit1345
pushed a commit
to Mohit1345/h2o-3
that referenced
this pull request
Aug 17, 2023
mn-mikke
added a commit
that referenced
this pull request
Oct 10, 2023
…_status() in h20.py #7079 [nocheck] (#15653) * [GH-15687] Extract string comparators from Duke library (#15692) * [GH-15680] Adding installation disclaimer in documentation (#15681) * ht/adding disclaimer in docs * ht/added flow & download page * ht/updated download page * ht/added security documentation section * ht/user guide updates * ht/uniformity * ht/added additional note to welcome page * callouts * ht/banner color switch * ht/rename callout --------- Co-authored-by: Jeff Fohl <[email protected]> * GH-15672: Tomas Fryda suggested instead of changing every test, the change should be made in standalone test. He provides the code and I just copied and pasted. (#15675) * Added verbose paramerter to init() in h2o.py also guarded h2oconn.cluster.show_status() * changes verbose param position before ** kwargs * final commit * removed space, and made it in rel-3.42.0 * added space --------- Co-authored-by: Marek Novotný <[email protected]> Co-authored-by: Hannah <[email protected]> Co-authored-by: Jeff Fohl <[email protected]> Co-authored-by: wendycwong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #15687
The PR extracts string comparators https://github.com/larsga/Duke library and makes part of the repository.