[GH-7079] Added verbose param to h2o.init() and guarded h2o.conn.show_status() in h20.py #7079 [nocheck] #15653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mn-mikke
previously approved these changes
Jul 28, 2023
h2o-py/h2o/h2o.py
Outdated
| @@ -136,7 +136,7 @@ def connection(): | |||
| def init(url=None, ip=None, port=None, name=None, https=None, cacert=None, insecure=None, username=None, password=None, | |||
| cookies=None, proxy=None, start_h2o=True, nthreads=-1, ice_root=None, log_dir=None, log_level=None, | |||
| max_log_file_size=None, enable_assertions=True, max_mem_size=None, min_mem_size=None, strict_version_check=None, | |||
| ignore_config=False, extra_classpath=None, jvm_custom_args=None, bind_to_localhost=True, **kwargs): | |||
| ignore_config=False, extra_classpath=None, jvm_custom_args=None, bind_to_localhost=True,verbose = True, **kwargs): | |||
There was a problem hiding this comment.
@mn-mikke last commit "added space" is rebased and also space is added in it
mn-mikke
changed the title
|
Please rebase the change to |
wendycwong
changed the title
…i#15681) * ht/adding disclaimer in docs * ht/added flow & download page * ht/updated download page * ht/added security documentation section * ht/user guide updates * ht/uniformity * ht/added additional note to welcome page * callouts * ht/banner color switch * ht/rename callout --------- Co-authored-by: Jeff Fohl <[email protected]>
…the change should be made in standalone test. He provides the code and I just copied and pasted. (h2oai#15675)
…ster.show_status()
Mohit1345
force-pushed
the
added_verbose_param
branch
from
74c62ee
to
0332bca
Compare
valenad1
reviewed
Oct 9, 2023
valenad1
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7079
1.Added verbose parameter to init() in h2o.py, allowing users to control the verbosity during initialization.
2. The 'verbose' parameter is set to True by default (similar to h2o.connect() as said in issue).
3.The h2oconn.cluster.show_status() call is now guarded and will be executed only when 'verbose' is True.
4.Additionally, a comment has been added to the h2o.init() function to explain the purpose of the 'verbose' parameter and its default value.
Fixes #7079