Revert "Change Round Robin and WeightedRoundRobin into petiole polices (#10528) #10575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es (grpc#10528)" This reverts commit e1334ea.
a0464e3
to
ca69df7
Compare
|
Need an approver, but everyone is already OOO. |
DNVindhya
approved these changes
Sep 26, 2023
ejona86
reviewed
Oct 2, 2023
| @@ -53,7 +53,6 @@ dependencies { | |||
| implementation 'androidx.appcompat:appcompat:1.0.0' | |||
|
|
|||
| // You need to build grpc-java to obtain these libraries below. | |||
| implementation 'io.grpc:grpc-core:1.59.0-SNAPSHOT' // CURRENT_GRPC_VERSION | |||
There was a problem hiding this comment.
This looks wrong. Nothing in this change should impact the dependencies needed by the examples. When we roll forward, we should not make this change and the change to proguard-rules.pro. The change to ManagedChannelImplTest.java is also suspicious.
(This sort of change was hard to spot in #10528 because the commits were broken and bringing in changes that already happened no master (e.g., README.md for the new release, java_grpc_library.bzl).)
DNVindhya
pushed a commit
to DNVindhya/grpc-java
that referenced
this pull request
Oct 5, 2023
…es (grpc#10528)" (grpc#10575) This reverts commit e1334ea.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A problem has been seen in G3 where //apiserving/performance:esf_benchmarks_presubmit is getting DEADLINE_EXCEEDED exceptions that go away when 10528 is rolled back.
This reverts commit e1334ea.