Change Round Robin and WeightedRoundRobin into petiole policies #10528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ejona86 do you have time to review? I have limited capacity so I would be very slow here. |
|
I'm unlikely to get to it before Tuesday, but I can take a look. |
Blocking can be confused with the blocking stub, which is unrelated. I'm purposefully not saying "it is used only for X," as that isn't what we need from the API. But it is still helpful to users to describe the sorts of things that use it. Fixes grpc#10508
Fixes grpc#10474 and b/273930962
When a memory leak occurs, it is really helpful to have access records to understand where the buffer was being held when it leaked. retain() when we create the NettyReadableBuffer already creates an access record the ByteBuf, so here we track when the ByteBuf is passed to another thread. See grpc#8330
temawi
reviewed
Sep 8, 2023
There was a problem hiding this comment.
I didn't review the original PR that introduced MultiChildLoadBalancer so some of my questions may be a bit ignorant and answered elsewhere, but humor me :-)
PR is pretty big with lot of intricate logic, so it was hard to wrap my brain around everything. Might still need to look at some things, but here's at least my initial thoughts.
xds/src/main/java/io/grpc/xds/WeightedRoundRobinLoadBalancer.java
Outdated
Show resolved
Hide resolved
Since 3b61799 OkHttp can support Grpc.newServerBuilderForPort().
Java 20+ don't support --release 7, so we just will use the default (8).
…ildren just to immediately delete them.
AndroidComponentAddress now accepts an Intent with merely a package restriction, not a full ComponentName. This lets clients avoid hard coding Service class names that they don't control. Fixes grpc#9062
It is slow, and just tries a bunch of possibilities. Leave it around for developers to run locally, but it isn't precise enough to run on every build. This change reduces the build of servlet in isolation by 1 minute. I suspect the gains are larger in a full grpc build because it is very CPU-intensive; it uses 600% CPU on my 8-thread CPU when running by itself.
temawi
approved these changes
Sep 13, 2023
…ildren just to immediately delete them.
larry-safran
added a commit
to larry-safran/grpc-java
that referenced
this pull request
Sep 26, 2023
…es (grpc#10528)" This reverts commit e1334ea.
larry-safran
added a commit
to larry-safran/grpc-java
that referenced
this pull request
Sep 26, 2023
…es (grpc#10528)" This reverts commit e1334ea.
DNVindhya
pushed a commit
to DNVindhya/grpc-java
that referenced
this pull request
Oct 5, 2023
…#10528) * Change Round Robin and WeightedRoundRobin into petiole policies
DNVindhya
pushed a commit
to DNVindhya/grpc-java
that referenced
this pull request
Oct 5, 2023
…es (grpc#10528)" (grpc#10575) This reverts commit e1334ea.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update MultiChildLoadBalancer to support changes needed for WRR.
Move deletion timer from MultiChildLoadBalancer back to ClusterManagerLoadBalancer as it only applies in the xds cluster case.
Add a generic Helper class for testing so that the mocks can delegate to it instead of complex when clauses. Not only simpler, but allows debugging.