stickiness: avoid using unsafe #2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
App Engine doesn't allow use of unsafe
dfawley
reviewed
Apr 24, 2018
| } | ||
| return "" | ||
| // No need to check ok because mdKey == "" if ok == false. | ||
| mdKey, _ := bp.stickinessMDKey.Load().(string) |
There was a problem hiding this comment.
return bp.stickinessMDKey.Load().(string)
There was a problem hiding this comment.
It could be nil. We need , _ otherwise it may panic.
| oldKeyUnsafePtr := atomic.SwapPointer(&bp.stickinessMDKey, unsafe.Pointer(&newKey)) | ||
| if ptr := (*string)(oldKeyUnsafePtr); ptr == nil || *ptr != newKey { | ||
| // No need to check ok because mdKey == "" if ok == false. | ||
| if oldKey, _ := bp.stickinessMDKey.Load().(string); oldKey != newKey { |
dfawley
approved these changes
Apr 24, 2018
menghanl
referenced
this pull request
Apr 25, 2018
menghanl
added a commit
to menghanl/grpc-go
that referenced
this pull request
Jun 25, 2018
This reverts commit 7263089.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
App Engine doesn't allow use of unsafe
#2022