Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"unsafe" dependency causing App Engine to break #2022

Closed
colesimmons opened this issue Apr 24, 2018 · 2 comments
Closed

"unsafe" dependency causing App Engine to break #2022

colesimmons opened this issue Apr 24, 2018 · 2 comments
Assignees
Labels
P1 Type: Dependencies Updating/adding/removing dependencies

Comments

@colesimmons
Copy link

colesimmons commented Apr 24, 2018

Please answer these questions before submitting your issue.

What version of gRPC are you using?

1.11.3

What version of Go are you using (go version)?

1.8

What operating system (Linux, Windows, …) and version?

macOS 10.13.1

What did you do?

First of all, I'd like to apologize if this a dumb issue, but I don't have a ton of experience with Go and its dependency management system!

I've been using the Firebase Admin SDK which has gRPC as a dependency. I ran go get -u earlier, which upgraded, among other things, gRPC to the commit made today where unsafe is included as a dependency. unsafe is not compatible with the App Engine Go Standard Environment, so this has been a massively breaking change.

What did you expect to see?

Successful build

What did you see instead?

go-app-builder: Failed parsing input: parser: bad import "unsafe" in google.golang.org/grpc/backoff.go from GOPATH

@menghanl
Copy link
Contributor

fixed by #2023

@colesimmons
Copy link
Author

Thank you!

@lock lock bot locked as resolved and limited conversation to collaborators Oct 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P1 Type: Dependencies Updating/adding/removing dependencies
Projects
None yet
Development

No branches or pull requests

3 participants