Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Example Apps #218

Merged
merged 2 commits into from
May 23, 2019
Merged

Fix Example Apps #218

merged 2 commits into from
May 23, 2019

Conversation

jnak
Copy link
Collaborator

@jnak jnak commented May 23, 2019

  • Update requirements.txt so they point at the local version of graphene-sqlalchemy
  • Use absolute imports in nameko_sqlalchemy because ./run.sh does not support absolute imports

@jnak jnak requested a review from Cito May 23, 2019 18:20
@jnak jnak mentioned this pull request May 23, 2019
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.988% when pulling f4b67a8 on jnak:example-readme into db3e9f4 on graphql-python:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.988% when pulling f4b67a8 on jnak:example-readme into db3e9f4 on graphql-python:master.

@coveralls
Copy link

coveralls commented May 23, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 93.988% when pulling e13494b on jnak:example-readme into db3e9f4 on graphql-python:master.

Cito
Cito previously approved these changes May 23, 2019
View reviewed changes
Copy link
Member

@Cito Cito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, including the nameko example. Looks good.

Both READMEs talk about "cloning the whole Graphene repository". It should be "Graphene-SQLAlchemy repository" instead. Maybe you can fix that as well in this PR.

@jnak
Copy link
Collaborator Author

jnak commented May 23, 2019

@Cito Sure. You have to re-approve the PR

@jnak jnak merged commit 9594587 into graphql-python:master May 23, 2019
@jnak jnak mentioned this pull request May 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cito Cito Cito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jnak @coveralls @Cito