Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release version 2.2.0 #217

Merged
merged 2 commits into from
May 28, 2019
Merged

Release version 2.2.0 #217

merged 2 commits into from
May 28, 2019

Conversation

jnak
Copy link
Collaborator

@jnak jnak commented May 23, 2019

Changelog

  • Improve creation of column and sort enums (db3e9f4)

@jnak jnak requested a review from Cito May 23, 2019 16:14
@jnak
Copy link
Collaborator Author

jnak commented May 23, 2019

@Cito This is releasing your enum PR. This will make it easier for people to follow the enum example

@coveralls
Copy link

coveralls commented May 23, 2019

Coverage Status

Coverage remained the same at 93.988% when pulling ca7be29 on jnak:rel-2.2.0 into 9594587 on graphql-python:master.

@Cito
Copy link
Member

Cito commented May 23, 2019

@jnak - I think we should also change the requirements.txt file like I sugested in #216. Since the ReadMe in the example directory recommends cloning from GitHub, we should install the currently cloned version instead of the version released on PyPI in order to make sure they always fit together. Also the current requirements.txt file has a version restriction for SQLAlchemy that is incompatible with the current restriction in our setup.py, so it needs to be fixed anyway.

@jnak
Copy link
Collaborator Author

jnak commented May 28, 2019

@Cito Now that #218 is merged, can you also accept this one so people can start using your change? Some issues were opened that might be not be happening with your changes (ex #219).

@jnak jnak merged commit 3332f45 into graphql-python:master May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants