Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): type-check library in CI #586

Merged
merged 2 commits into from
May 24, 2024
Merged

chore(ci): type-check library in CI #586

merged 2 commits into from
May 24, 2024

Conversation

KnorpelSenf
Copy link
Member

How did we never type-check grammY in CI? It currently fails and I only discovered this locally.

@winstxnhdw
Copy link
Member

winstxnhdw commented May 24, 2024

Do we have to add /// <reference types="npm:@types/node" /> in here as well? I always assumed deno task test also type-checks grammY, or at least it seems like it does since it fails whenever I make any type errors that are also not runtime errors.

@KnorpelSenf
Copy link
Member Author

I assumed the same thing. It might only check test files, not all modules under test.

I don't think we can use triple-slash directives here because that would pollute the global types at runtime. We have to find a different way.

@winstxnhdw
Copy link
Member

Ok, let me handle this.

@KnorpelSenf KnorpelSenf merged commit b4c4e58 into main May 24, 2024
6 checks passed
@KnorpelSenf KnorpelSenf deleted the check-in-ci branch May 24, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants