Skip to content

Commit

Permalink
chore(ci): type-check library in CI (#586)
Browse files Browse the repository at this point in the history
* chore(ci): type-check library in CI

* fix: do not rely on nodejs types outside of tests

---------

Co-authored-by: winstxnhdw <[email protected]>
  • Loading branch information
KnorpelSenf and winstxnhdw committed May 24, 2024
1 parent bc23a3e commit b4c4e58
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/deno.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
deno-version: v1.x

- name: Cache Dependencies
run: deno cache src/mod.ts
run: deno task check

- name: Run Tests
run: deno task test
Expand Down
4 changes: 2 additions & 2 deletions src/convenience/frameworks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ export type HonoAdapter = (c: {
}) => ReqResHandler<Response>;

export type HttpAdapter = (req: {
headers: NodeJS.Dict<string | string[]>;
headers: Record<string, string | string[] | undefined>;
on: (event: string, listener: (chunk: unknown) => void) => typeof req;
once: (event: string, listener: () => void) => typeof req;
}, res: {
Expand All @@ -172,7 +172,7 @@ export type KoaAdapter = (ctx: {

export type NextAdapter = (req: {
body: Update;
headers: NodeJS.Dict<string | string[]>;
headers: Record<string, string | string[] | undefined>;
}, res: {
end: (cb?: () => void) => typeof res;
status: (code: number) => typeof res;
Expand Down

0 comments on commit b4c4e58

Please sign in to comment.