Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't automate the badge for All Contributors #207

Merged
merged 1 commit into from
May 15, 2022
Merged

Conversation

rojvv
Copy link
Member

@rojvv rojvv commented May 15, 2022

  • This maintains our custom styles and makes the style of the badge for All Contributors consistent with the others.
  • Related: Add Deno shield #197 (comment)

- This maintains our custom styles and makes the style of the badge for All Contributors consistent with the others.
- Related: #197 (comment)
@rojvv rojvv requested a review from KnorpelSenf May 15, 2022 19:37
@KnorpelSenf
Copy link
Member

Did you test this?

@rojvv
Copy link
Member Author

rojvv commented May 15, 2022

Do you mean testing if the badge works or testing to know if it is persisting after you send an All Contributors update?

If you mean the badge, you can preview it here: https://github.com/grammyjs/grammY/tree/all-contributors

@KnorpelSenf
Copy link
Member

I meant running the tooling and making sure things aren't overwritten.

Copy link
Member

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it now, it works. Thanks!

@KnorpelSenf KnorpelSenf merged commit 487f37d into main May 15, 2022
@KnorpelSenf KnorpelSenf deleted the all-contributors branch May 15, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants