Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Deno shield #197

Merged
merged 2 commits into from
May 10, 2022
Merged

Add Deno shield #197

merged 2 commits into from
May 10, 2022

Conversation

rojvv
Copy link
Member

@rojvv rojvv commented May 10, 2022

No description provided.

@rojvv rojvv requested a review from KnorpelSenf May 10, 2022 09:37
@rojvv
Copy link
Member Author

rojvv commented May 10, 2022

If its style not matching with the other badges is a problem, we can modify the styles of the shieldsio badges. The style of the Deno shield is not modifiable.

@KnorpelSenf
Copy link
Member

KnorpelSenf commented May 10, 2022

Yes, please align the designs before we merge this.

@rojvv
Copy link
Member Author

rojvv commented May 10, 2022

@KnorpelSenf How are they looking now?

@EdJoPaTo
Copy link
Member

EdJoPaTo commented May 10, 2022

image

Copy link
Member

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! Good idea :)

@KnorpelSenf KnorpelSenf merged commit 5555c4c into main May 10, 2022
@KnorpelSenf KnorpelSenf deleted the deno-shield branch May 10, 2022 10:23
@KnorpelSenf
Copy link
Member

KnorpelSenf commented May 10, 2022

In fact, img.shields.io allows us to use any logo, text, and design. If we want, we could switch back to the old designs, and simply avoid pulling in the Deno shield from deno.dev. What do you think?

@HeeroML

This comment was marked as off-topic.

@rojvv
Copy link
Member Author

rojvv commented May 10, 2022

@KnorpelSenf If you prefer, we can remove the version part on the npm badge and do all of the work with shieldsio.

@KnorpelSenf
Copy link
Member

I think it makes a lot of sense to have the same version on both shields. That way, it's very clear how we publish the identical versions for both runtimes.

@rojvv
Copy link
Member Author

rojvv commented May 10, 2022

That way you should use the Deno shield. Because there won't be a way to add the version to a manually made shieldsio badge, and it won't look cool if we have the version on the npm badge, but not on the Deno one.

@KnorpelSenf
Copy link
Member

Ah right, good point, I did not think about that. In that case, we can leave things as they are now.

@EdJoPaTo
Copy link
Member

Alternatively… isnt shields.io open source? 😏

@KnorpelSenf
Copy link
Member

You want to fork and add the feature we need?

@rojvv
Copy link
Member Author

rojvv commented May 10, 2022

@EdJoPaTo Does that mean you will host your instance with this feature, or do you mean to PR this feature? They don’t accept PRs easily. Reference: badges/shields#7831

@KnorpelSenf
Copy link
Member

It seems like there is progress on the linked PQ now.

@rojvv
Copy link
Member Author

rojvv commented May 10, 2022

Yes, happily.

@KnorpelSenf
Copy link
Member

@roj1512 this PQ modified the section controlled by all-contributors. The styling will be overwritten whenever a new contributor gets listed in the README.

Should we maybe switch to the automatically generated badge the is described in all-contributors/all-contributors#406?

rojvv added a commit that referenced this pull request May 15, 2022
- This maintains our custom styles and makes the style of the badge for All Contributors consistent with the others.
- Related: #197 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants