Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Channel Based Streaming of Frames #5

Closed
suyashkumar opened this issue Jun 29, 2018 · 0 comments · Fixed by #21
Closed

Implement Channel Based Streaming of Frames #5

suyashkumar opened this issue Jun 29, 2018 · 0 comments · Fixed by #21
Assignees
Labels
enhancement New feature or request

Comments

@suyashkumar
Copy link
Contributor

Stream frame packages as they are parsed over channels to any consumers that want them.

@suyashkumar suyashkumar added the enhancement New feature or request label Jun 29, 2018
@suyashkumar suyashkumar self-assigned this Jun 29, 2018
suyashkumar added a commit that referenced this issue Jul 9, 2018
This change refactors the core `go-dicom` API to use an interface called `Parser`. This allows for more elegant dependency injection of items (like channels, previous data elements) with a clean end user api (so that the user doesn't have to worry about passing in those references themselves). Using an interface like this will also make typical testing easier on the end user, and is also more canonical golang imho. This closes #11 and addresses #3. This also puts some plumbing in place for #5.
suyashkumar added a commit that referenced this issue Jul 13, 2018
This change builds upon previous changes to implement functionality to stream frames to a channel as they are parsed out of a dicom. This change also updates the dicomutil command line client to optionally use this new functionality. This closes #5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant