-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate Code Quality of Existing Code #3
Labels
Comments
suyashkumar
added a commit
that referenced
this issue
Jul 9, 2018
This change refactors the core `go-dicom` API to use an interface called `Parser`. This allows for more elegant dependency injection of items (like channels, previous data elements) with a clean end user api (so that the user doesn't have to worry about passing in those references themselves). Using an interface like this will also make typical testing easier on the end user, and is also more canonical golang imho. This closes #11 and addresses #3. This also puts some plumbing in place for #5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Audit existing code quality, identify any areas necessary for refactors.
The text was updated successfully, but these errors were encountered: