Implement streaming frames as they are parsed #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suyashkumar
commented
Jul 13, 2018
| ) | ||
|
|
||
| // FrameBufferSize represents the size of the *Frame buffered channel for streaming calls | ||
| const FrameBufferSize = 100 |
There was a problem hiding this comment.
pretty cheap since we're storing *Frame, shouldn't have over a 100 frames build up in the buffer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change builds upon previous changes to implement functionality to stream frames to a channel as they are parsed out of a dicom. This change also updates the
dicomutilcommand line client to optionally use this new functionality. This closes #5.