Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework how disabling of toolchain detection works #184

Merged
merged 4 commits into from
Dec 20, 2021
Merged

Commits on Dec 20, 2021

  1. Rework how disabling of toolchain detection works

    Disabling the toolchain detection by tasks wasn't sufficient,
    because Gradle would use the nested `BaseImageOptions` as an input,
    and even if the particular `JavaLauchner` input wasn't used if that
    flag was disabled, it would still be used internally by Gradle to
    snapshot inputs.
    
    As a consequence, the fix only worked if Gradle actually detected
    a GraalVM installation somewhere, even if it didn't use it!
    
    To fix this, this commit introduces a top-level DSL method called
    `disableToolchainDetection()` which effectively sets the toolchain
    to `null` by convention. By making the toolchain optional and null
    now Gradle wouldn't complain anymore.
    
    Fixes #183
    melix committed Dec 20, 2021
    Configuration menu
    Copy the full SHA
    0c4e30b View commit details
    Browse the repository at this point in the history
  2. Fix injection for Gradle <7

    melix committed Dec 20, 2021
    Configuration menu
    Copy the full SHA
    79b2a67 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6be2704 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    88219c4 View commit details
    Browse the repository at this point in the history