Rework how disabling of toolchain detection works #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disabling the toolchain detection by tasks wasn't sufficient, because Gradle would use the nested `BaseImageOptions` as an input, and even if the particular `JavaLauchner` input wasn't used if that flag was disabled, it would still be used internally by Gradle to snapshot inputs. As a consequence, the fix only worked if Gradle actually detected a GraalVM installation somewhere, even if it didn't use it! To fix this, this commit introduces a top-level DSL method called `disableToolchainDetection()` which effectively sets the toolchain to `null` by convention. By making the toolchain optional and null now Gradle wouldn't complain anymore. Fixes #183
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabling the toolchain detection by tasks wasn't sufficient,
because Gradle would use the nested
BaseImageOptionsas an input,and even if the particular
JavaLauchnerinput wasn't used if thatflag was disabled, it would still be used internally by Gradle to
snapshot inputs.
As a consequence, the fix only worked if Gradle actually detected
a GraalVM installation somewhere, even if it didn't use it!
To fix this, this commit introduces a top-level DSL method called
disableToolchainDetection()which effectively sets the toolchainto
nullby convention. By making the toolchain optional and nullnow Gradle wouldn't complain anymore.
Fixes #183