Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run artman smoketests in googleapis circleci project #474

Merged
merged 2 commits into from
Oct 9, 2017

Conversation

ethanbao
Copy link
Contributor

@ethanbao ethanbao commented Oct 6, 2017

Using the same smoketest script that artman uses. Different from the circleci task, we uses a stable artman image to run the smoketests. This way, we can be notified if one googleapis commit causes some artifact fail to generate. Currently, some artifacts fail to generate, causing noisyness. This task will be more useful once all artifacts in googleapis are working.

@geigerj
Copy link
Contributor

geigerj commented Oct 6, 2017

Given that this repo is now entirely mechanically synchronized, wouldn't it be more useful to do this internally, upstream?

@geigerj
Copy link
Contributor

geigerj commented Oct 9, 2017

@ethanbao From offline discussion, I understand that there are difficulties in doing this upstream. However, I am concerned that alone this will not be beneficial unless we plan to set up an alert system. Team members don't do much (if any) manual monitoring of this repo.

@ethanbao
Copy link
Contributor Author

ethanbao commented Oct 9, 2017

Setup a alert/notification is a different topic. Just because people doesn't follow the law doesn't mean there is no need to write the law. The law enforcement can be addressed separately. It would be nice if we can enforce something before bad things to happen. But sometimes it could be hard, so post-crisis enforcement will still benefit our stack. We can have monitoring as part of oncall rotation. At minimal, is we will be able to trace and check which PR/commit caused an artifact fail to build.

@geigerj
Copy link
Contributor

geigerj commented Oct 9, 2017

@ethanbao Acknowledged. I just think that at a pragmatic level this will not have as much impact as it should. We don't even have an effective process for triaging issues in this repo currently.

@ethanbao ethanbao merged commit 438e7d6 into googleapis:master Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants