Introduce a "build_and_push_docker_image" job in artman/circleci #298
Conversation
There was a problem hiding this comment.
just nits, but please have @lukesneeringer take a look too, since I'm not too familiar with CircleCI
.circleci/config.yml
Outdated
| command: | | ||
| docker run -it -e RUNNING_IN_ARTMAN_DOCKER=True -v /tmp/reports:/tmp/reports artman /bin/bash -c "pip install pytest; git clone https://github.com/googleapis/googleapis /artman/test/golden/googleapis; py.test /artman/test/golden/artman_golden_test.py --googleapis-dir=/artman/test/golden/googleapis" | ||
| # When build performance is a concern, consider separting this job into | ||
| # a workflow with multiple jobs and have the smoketest run in parrall |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
.circleci/config.yml
Outdated
| name: Run golden tests | ||
| command: | | ||
| docker run -it -e RUNNING_IN_ARTMAN_DOCKER=True -v /tmp/reports:/tmp/reports artman /bin/bash -c "pip install pytest; git clone https://github.com/googleapis/googleapis /artman/test/golden/googleapis; py.test /artman/test/golden/artman_golden_test.py --googleapis-dir=/artman/test/golden/googleapis" | ||
| # When build performance is a concern, consider separting this job into |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
.circleci/config.yml
Outdated
| docker run -it -e RUNNING_IN_ARTMAN_DOCKER=True -v /tmp/reports:/tmp/reports artman /bin/bash -c "pip install pytest; git clone https://github.com/googleapis/googleapis /artman/test/golden/googleapis; py.test /artman/test/golden/artman_golden_test.py --googleapis-dir=/artman/test/golden/googleapis" | ||
| # When build performance is a concern, consider separting this job into | ||
| # a workflow with multiple jobs and have the smoketest run in parrall | ||
| # with additional paied containers. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
.circleci/config.yml
Outdated
| name: Run smoketests | ||
| command: | | ||
| mkdir /tmp/reports | ||
| echo "this is a test" >> /tmp/reports/smoketest.log |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
.circleci/config.yml
Outdated
| - checkout | ||
| - setup_remote_docker | ||
| - run: | ||
| name: Finger crossed! |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
The performance gain is substantial. Saved 20+ mins in building time. More importantly, it is the same cached layer when pushing to Dockerhub, meaning the downstream users will not need to download the whole image for a new docker image in most cases. |
|
Merged, thank you for the review. There is a similar CI PR in googleapis repo: googleapis/googleapis#474. PTAL. While running the same smoketest script, the googleapis PR uses different artman docker image for different purpose. |
…ing other repos to use this repo as bazel repo dependency. (googleapis#298)
This is a example when the tasks runs:
https://circleci.com/gh/ethanbao/artman/410
The smoketest (all) will fail, but I manually disabled the smoketest and confirmed that the deploy step will work (see https://hub.docker.com/r/googleapis/artman/tags/ for an auto-build artman docker image).