-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rust] Provide option to override default package / file names #5054
Comments
@aardappel Do you have any thoughts on how to re-use functionality for this from the other language ports? |
I am not sure what the problem is. Your schemas have e.g. Why do the files have to be renamed?
|
The issue I'm having is described well in #342 but the summary is that the Java-style namespace specified in the schema file is not friendly for Rust. The flatc generator has namespace overrides for some languages but not Rust. I guess I am requesting that feature e.g. |
I generated the IPC code after installing the flatbuffers release available via conda but still had to manually modify the code to make it compile due to these issues with flatbuffers: google/flatbuffers#5052 google/flatbuffers#5053 google/flatbuffers#5054 I think this is the best we can do for now. Author: Andy Grove <[email protected]> Closes #4021 from andygrove/rust-ipc and squashes the following commits: 7a549be <Andy Grove> encode field data type ab769bb <Andy Grove> delete file a81bee9 <Andy Grove> fix CI 1bbc4a7 <Andy Grove> Update README 83f3b4c <Andy Grove> Add generated IPC code
I would like to remove the Thanks |
I'm having the same problem as @rope-hmg. I'd like to to rename my What would be great to have is a switch |
Might be worth creating a separate issue that is not Rust-specific. |
This issue is stale because it has been open 6 months with no activity. Please comment or this will be closed in 14 days. |
I generated the IPC code after installing the flatbuffers release available via conda but still had to manually modify the code to make it compile due to these issues with flatbuffers: google/flatbuffers#5052 google/flatbuffers#5053 google/flatbuffers#5054 I think this is the best we can do for now. Author: Andy Grove <[email protected]> Closes #4021 from andygrove/rust-ipc and squashes the following commits: 7a549be9e <Andy Grove> encode field data type ab769bba5 <Andy Grove> delete file a81bee9b3 <Andy Grove> fix CI 1bbc4a76b <Andy Grove> Update README 83f3b4c06 <Andy Grove> Add generated IPC code
Language: Rust
OS: Ubuntu 16.04
GCC: 5.4.0
When generating Rust code, I could not find any option to specify a package name to use and had to hand-modify the generated code to use the desired package name. I also had to rename the generated files to remove the
_generated
suffix and make the file names lower case.The text was updated successfully, but these errors were encountered: