[Rust] Generated code produces warnings about snake case / camel case

[andygrove]

Language: Rust
OS: Ubuntu 16.04
GCC: 5.4.0

Because flatbuffers files are intended for use across multiple languages, there is no guarantee that the generated code will use Rust style snake case etc, leading to compiler warnings.

It would be good to have the option of either generating idiomatic Rust code, or generating these directives to disable the warnings:

#![allow(non_snake_case)]
#![allow(non_camel_case_types)]

[aardappel]

Since FlatBuffers started with C++, it was assumed that schemas would be written in snake_case for fields (which corresponds to most C++ style guides), and then we added ways to convert those to various camels for Java/C# etc. But yes, we don't enforce this, and we don't do the reverse if someone writes their schemas in a camel case. Maybe we should.

[rw]

@andygrove You can see here that we already emit these directives in some cases:

flatbuffers/tests/monster_test_generated.rs

Line 1252 in 980a6d6

#[allow(non_snake_case)]

Would you be able to point out where else the directives should be emitted? Thanks!

[aardappel]

Also note the FlatBuffers style guide says things like field names should already be snake_case: https://google.github.io/flatbuffers/flatbuffers_guide_writing_schema.html (under "style guide"). Which identifiers have the wrong case?

[stale]

This issue has been automatically marked as stale because it has not had activity for 6 months. It will be closed if no further activity occurs. Thank you for your contributions.