Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move MoreTypes code to common module. #923

Merged
merged 6 commits into from
Nov 18, 2021
Merged

Conversation

santosh-pingle
Copy link
Collaborator

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Description

  1. Merge validation/MoreTypes and MoreTypes files which are present in sdc library and move it to common module.
  2. Move respective tests to common module.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: Code health

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct
  • I have read How to Contribute
  • I have read the Developer's guide
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally
  • I have built and run the reference app(s) to verify my change fixes the issue and/or does not break the reference app(s)

@santosh-pingle santosh-pingle changed the title Sp/moretypes common Move MoreTypes code to common module. Nov 15, 2021
@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #923 (12f57eb) into master (0f3ae42) will decrease coverage by 0.21%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #923      +/-   ##
============================================
- Coverage     88.59%   88.38%   -0.22%     
  Complexity      464      464              
============================================
  Files           106      106              
  Lines          9043     9056      +13     
  Branches        561      561              
============================================
- Hits           8012     8004       -8     
- Misses          743      761      +18     
- Partials        288      291       +3     
Impacted Files Coverage Δ
...fhir/datacapture/enablement/EnablementEvaluator.kt 73.68% <ø> (ø)
...acapture/validation/MaxValueConstraintValidator.kt 100.00% <ø> (ø)
...acapture/validation/MinValueConstraintValidator.kt 100.00% <ø> (ø)
...src/main/java/com/google/android/fhir/MoreTypes.kt 67.85% <80.00%> (ø)
...main/java/com/google/android/fhir/UnitConverter.kt 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f3ae42...12f57eb. Read the comment docs.

Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @santosh-pingle - as discussed offline, can you just add the common module to the coverage report in the ci.yml file?

@santosh-pingle
Copy link
Collaborator Author

thanks @santosh-pingle - as discussed offline, can you just add the common module to the coverage report in the ci.yml file?

done.

@santosh-pingle santosh-pingle enabled auto-merge (squash) November 18, 2021 05:46
@santosh-pingle santosh-pingle merged commit 4d3fc86 into master Nov 18, 2021
@santosh-pingle santosh-pingle deleted the sp/moretypes-common branch November 18, 2021 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants