Implement inequality operators (<, >, <=, >=) in the enable when statement

[santosh-pingle]

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #818

Description
Implement inequality operators (<, >, <=, >=) in the enable when statement

Alternative(s) considered
no

Type
Choose one: Bug fix

Screenshots (if applicable)

Checklist

• I have read and acknowledged the Code of conduct
• I have read How to Contribute
• I have read the Developer's guide
• I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA
• I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach
• I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project
• I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally
• I have built and run the reference app(s) to verify my change fixes the issue and/or does not break the reference app(s)

[jingtang10]

please update this PR now that #847 is merged

[jingtang10]

please udpate

[santosh-pingle]

Updating PR.

[codecov]

Codecov Report

Merging #848 (edeff1d) into master (e3b7e7e) will increase coverage by 0.13%.
The diff coverage is 76.92%.

@@             Coverage Diff              @@
##             master     #848      +/-   ##
============================================
+ Coverage     88.55%   88.68%   +0.13%     
- Complexity      467      469       +2     
============================================
  Files           107      107              
  Lines          9137     9147      +10     
  Branches        609      614       +5     
============================================
+ Hits           8091     8112      +21     
+ Misses          715      704      -11     
  Partials        331      331              

Impacted Files	Coverage Δ
...src/main/java/com/google/android/fhir/MoreTypes.kt	79.41% <72.72%> (+11.55%)	⬆️
...fhir/datacapture/enablement/EnablementEvaluator.kt	78.26% <100.00%> (+4.57%)	⬆️
...main/java/com/google/android/fhir/UnitConverter.kt	69.23% <0.00%> (+69.23%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3b7e7e...edeff1d. Read the comment docs.

[santosh-pingle]

@jingtang10
Can you please review it?
I will check whether I can add more tests to increase code coverage.

[jingtang10]

as discussed, merge the MoreTypes.kt files and move it to the common module and use the Type.compareTo rather than defining the extension functions on the QuestionnaireItemEnableWhenComponent.

[santosh-pingle]

Working on review comments.

[santosh-pingle]

#923 (move moretypes file to common module)

[santosh-pingle]

as discussed, merge the MoreTypes.kt files and move it to the common module and use the Type.compareTo rather than defining the extension functions on the QuestionnaireItemEnableWhenComponent.

done.

[jingtang10]

In general we shouldn't be making any code change without unit test change.

If MoreTypes.kt file is changed please add unit tests as well.

I don't believe the quantity type needs to be singled out in the unit test for the enablement evaluator -- that's an irrelevant detail in the code of enablement evaluator. but that's a relevant detail in the MoreTypes.kt file, so the tests should reside there.

[santosh-pingle]

yes, quantity tests need to be moved to MoreTypes.kt, thanks!

[santosh-pingle]

Updating code as per review comments.

[jingtang10]

Thanks @santosh-pingle!