Add tests for API 30, cache AVD #619
Conversation
This PR adds testing for API 30 devices. * Cleaned up the CI build a bit to explicitly have a matrix parameter for full build. * Added cache for AVD
yigit
requested review from
aditya-07,
deepankarb,
jingtang10,
kevinmost,
pankajkatoch and
stevenckngaa
as code owners
|
btw this is not ready to be reviwed, still trying to figure out why the filter are not working . |
| - name: Run Integration Tests | ||
| uses: reactivecircus/android-emulator-runner@v2 | ||
| with: | ||
| api-level: ${{ matrix.api-level }} | ||
| arch: x86_64 | ||
| emulator-build: 7425822 # https://github.com/ReactiveCircus/android-emulator-runner/issues/160 |
There was a problem hiding this comment.
The emulator seems to be working fine because we are using macos-11 (private preview). If we want this change maybe we could also downgrade the runner to macos-latest? But then why not use the latest version?
Why is api30 not working😭
Hi @yigit , did you get a chance to look into this query? |
There was a problem hiding this comment.
@yigit do you still want to work on this or should we close this?
@yigit , @jingtang10 , are there changes still pending or can this be closed? |
jingtang10
force-pushed
the
yigit/add-api-30-tests
branch
from
9d600b9
to
33297cb
Compare
|
chatted with @yigit. agreed to close this since a lot has changed and we'll probably use gradle build actions. |
This PR adds testing for API 30 devices.
Fixes #617
Test: CI