Update GitHub Actions workflow steps with names #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds testing for API 30 devices. * Cleaned up the CI build a bit to explicitly have a matrix parameter for full build. * Added cache for AVD
Why is api30 not working😭
jingtang10
requested review from
aditya-07,
deepankarb,
kevinmost,
stevenckngaa and
yigit
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1136 +/- ##
=========================================
Coverage 84.52% 84.52%
Complexity 608 608
=========================================
Files 134 134
Lines 10279 10279
Branches 756 756
=========================================
Hits 8688 8688
Misses 1215 1215
Partials 376 376 Continue to review full report at Codecov.
|
yigit
approved these changes
Feb 8, 2022
There was a problem hiding this comment.
this lgtm. Btw, it is probably worth keeping an eye on v2 of gradle build action.
https://github.com/gradle/gradle-build-action
We recently migrated AndroidX to that, it is still WIP though but handles some caching etc for you.
ktarasenko
pushed a commit
that referenced
this pull request
Feb 16, 2022
* Add tests for API 30, cache AVD This PR adds testing for API 30 devices. * Cleaned up the CI build a bit to explicitly have a matrix parameter for full build. * Added cache for AVD * fix parameter syntax * fix include * remove avd cache, seems to be causing issues. can try again later * fix typo * add workaround for emulator connection issues * Trying using x86 arch * Try default target Why is api30 not working😭 * Format ci.yml * Add back the jacoco test report steps * Add a new line at the bottom of ci.yml * Update the workflow test step name Co-authored-by: Yigit Boyar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Description
An update on #619
Alternative(s) considered
NA
Type
Builds
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project./gradlew checkand./gradlew connectedCheckto test my changes locally