Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove submit and cancel visibility style. #2428

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

santosh-pingle
Copy link
Collaborator

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #[issue number]

Description
No more visibility style is required to control the appearance of Submit and Cancel Button.
It is controlled by flags.

Alternative(s) considered
Visibility is controlled by flags.

Type
Choose one: Bug fix.

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@santosh-pingle santosh-pingle marked this pull request as ready for review February 5, 2024 10:49
@santosh-pingle santosh-pingle requested a review from a team as a code owner February 5, 2024 10:49
@santosh-pingle santosh-pingle linked an issue Feb 5, 2024 that may be closed by this pull request
@jingtang10 jingtang10 merged commit a5ef8cd into google:master Feb 6, 2024
3 checks passed
@jingtang10
Copy link
Collaborator

thanks @santosh-pingle!

sharon2719 pushed a commit to opensrp/android-fhir that referenced this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Control submit button visibility using a fragment argument
2 participants