Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control submit button visibility using a fragment argument #1748

Closed
jingtang10 opened this issue Dec 4, 2022 · 6 comments · Fixed by #2428
Closed

Control submit button visibility using a fragment argument #1748

jingtang10 opened this issue Dec 4, 2022 · 6 comments · Fixed by #2428
Labels
effort:small Small effort - 2 days P2 Medium priority issue

Comments

@jingtang10
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
At the moment we control the visibility of the submit button using styling. But perhaps we should control it a bit more explicitly using a fragment arguement. I worry that we're using a style attribute to control a very important functional behavior of the sdc library.

Describe the solution you'd like
Create a new fragment argument

Describe alternatives you've considered

  • current approach

Additional context
NA

Would you like to work on the issue?
maybe

@jingtang10
Copy link
Collaborator Author

@santosh-pingle fyi

@jingtang10 jingtang10 changed the title Control submit button visibility using a parameter Control submit button visibility using a fragment argument Dec 4, 2022
@jingtang10
Copy link
Collaborator Author

@williamito fyi

@aditya-07 aditya-07 added effort:small Small effort - 2 days P2 Medium priority issue labels Dec 8, 2022
@devharsh2k4
Copy link

can i get assigned?

@jingtang10
Copy link
Collaborator Author

#1872

@jingtang10
Copy link
Collaborator Author

@santosh-pingle you might still need to remove the style declarations in the style files.

@jingtang10
Copy link
Collaborator Author

can i get assigned?

please take an issue labelled with good first issue. thanks!

@santosh-pingle santosh-pingle linked a pull request Feb 5, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort:small Small effort - 2 days P2 Medium priority issue
Projects
Status: Complete
Development

Successfully merging a pull request may close this issue.

3 participants