Add x-fhir-query enhancement #1844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omarismail94
requested review from
aditya-07,
deepankarb,
jingtang10,
jjtswan,
joiskash,
kevinmost,
ktarasenko,
santosh-pingle,
stevenckngaa,
vvikramraj,
wantingzhang77 and
yigit
as code owners
|
@omarismail94 @jingtang10 Just bringing awareness to this as I see this was marked for review 3 weeks ago but there hasn't been an update since. |
|
thanks @KhumboLihonga for the ping! We were busy working on the 1.0.0 SDC release and now that's over we can re-focus on this. I updated the PR and will talk to @jingtang10 and team on getting a review |
jingtang10
requested changes
Mar 2, 2023
datacapture/src/main/java/com/google/android/fhir/datacapture/mapping/ResourceMapper.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/fhirpath/ExpressionEvaluator.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireFragment.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireViewModel.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireViewModel.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireViewModel.kt
Outdated
Show resolved
Hide resolved
jingtang10
requested changes
Mar 24, 2023
There was a problem hiding this comment.
thanks omar - discussed... please see http:https://build.fhir.org/ig/HL7/sdc/StructureDefinition-sdc-questionnaire-launchContext.html and make sure we're matching the launch context code with the resource provided using the new arg.
datacapture/src/main/java/com/google/android/fhir/datacapture/extensions/MoreTypes.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireViewModel.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireViewModel.kt
Outdated
Show resolved
Hide resolved
...apture/src/test/java/com/google/android/fhir/datacapture/fhirpath/ExpressionEvaluatorTest.kt
Outdated
Show resolved
Hide resolved
...apture/src/test/java/com/google/android/fhir/datacapture/fhirpath/ExpressionEvaluatorTest.kt
Outdated
Show resolved
Hide resolved
jingtang10
reviewed
Mar 29, 2023
jingtang10
reviewed
Mar 29, 2023
datacapture/src/main/java/com/google/android/fhir/datacapture/extensions/MoreQuestionnaires.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/extensions/MoreQuestionnaires.kt
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireFragment.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireViewModel.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/extensions/MoreQuestionnaires.kt
Outdated
Show resolved
Hide resolved
datacapture/src/test/java/com/google/android/fhir/datacapture/QuestionnaireViewModelTest.kt
Outdated
Show resolved
Hide resolved
datacapture/src/test/java/com/google/android/fhir/datacapture/QuestionnaireViewModelTest.kt
Outdated
Show resolved
Hide resolved
datacapture/src/test/java/com/google/android/fhir/datacapture/QuestionnaireViewModelTest.kt
Show resolved
Hide resolved
...apture/src/test/java/com/google/android/fhir/datacapture/fhirpath/ExpressionEvaluatorTest.kt
Outdated
Show resolved
Hide resolved
...apture/src/test/java/com/google/android/fhir/datacapture/fhirpath/ExpressionEvaluatorTest.kt
Show resolved
Hide resolved
jingtang10
reviewed
Apr 4, 2023
...pture/src/test/java/com/google/android/fhir/datacapture/extensions/MoreQuestionnairesTest.kt
Outdated
Show resolved
Hide resolved
jingtang10
approved these changes
Apr 6, 2023
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1658
Description
MoreTypesclasses we haveAlternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
In this PR, we pass in the context as a JSON string which we then parse. I tried passing in the context as an ID only, so that it can be fetched, but we cannot use the xFhirQueryResolver to fetch the resource as the query
Resource/Iddoes not workType
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.