Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple resources to be set in context #2000

Merged
merged 10 commits into from
May 26, 2023
Merged

Allow multiple resources to be set in context #2000

merged 10 commits into from
May 26, 2023

Conversation

omarismail94
Copy link
Contributor

@omarismail94 omarismail94 commented May 4, 2023

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes: #1658

Description
Clear and concise code change description.

Allow multiple resources to be set in context

In the resource table, it says:

Context resources needed for Questionnaire

https://build.fhir.org/ig/HL7/sdc/StructureDefinition-sdc-questionnaire-launchContext.html

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@omarismail94 omarismail94 requested a review from a team as a code owner May 4, 2023 22:39
Copy link
Collaborator

@jingtang10 jingtang10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a test case that tests multiple contexts? i feel that it is not covered in the current test cases.

@omarismail94
Copy link
Contributor Author

can you add a test case that tests multiple contexts? i feel that it is not covered in the current test cases.

added a test case with multiple contexts in ExpressionEvaluatorTest

@jingtang10 jingtang10 merged commit b129c66 into google:master May 26, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Enhance x-fhir-query to handle fhirpath expression
3 participants