Show submit button in review mode. #1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditya-07
requested review from
deepankarb,
jingtang10,
jjtswan,
joiskash,
kevinmost,
ktarasenko,
omarismail94,
santosh-pingle,
stevenckngaa,
vvikramraj,
wantingzhang77 and
yigit
as code owners
There was a problem hiding this comment.
@aditya-07 can we please also add unit tests or android tests, if possible?
datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireFragment.kt
Show resolved
Hide resolved
Added some tests for checking the visibility of Submit Button and other Review State logic. |
jingtang10
requested changes
Jan 26, 2023
datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireFragment.kt
Outdated
Show resolved
Hide resolved
datacapture/src/test/java/com/google/android/fhir/datacapture/QuestionnaireViewModelTest.kt
Show resolved
Hide resolved
jingtang10
approved these changes
Feb 3, 2023
omarismail94
added a commit
that referenced
this pull request
Aug 16, 2023
…h type reference (#2065) * set the initial value using the initial expression extension for reference type * Allow developers to add custom search parameter to the engine. (#1778) * Added custom search paramter. * Review changes : Injecting ResourceIndexer into ResourceDao * Show submit button in review mode. (#1826) * Show submit button in review mode * Added tests * Review comments: Updated the fragment result listener to check explicit result values * Fix for removing old indexes when resource is updated (#1840) * Fix for removing old indexes when resource is updated * Added comments * add datacapture config in demo app * Fix dropdown initial selection for answerOptions of type Reference Sometimes choiceColumn evaluated to similar 'display' text across many options, and the autocompletetextview text would get set to null * Support expression evaluating to ResourceType for items of type Reference * Update autocompleteTextView to check answerId * Add AutoCompleteViewHolderFactory ui tests * Fix failing tests for AutoCompleteViewHolderFactory * Refactor MoreTypes.kt to remove duplications Co-authored-by: Omar Ismail <[email protected]> * Refactor evaluation of questionnaireItem initial value * Fix AutoCompleteTextViewFactory espresso test failing in api 24 --------- Co-authored-by: omarismail <[email protected]> Co-authored-by: aditya-07 <[email protected]> Co-authored-by: Omar Ismail <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1817
Description
QuestionnaireValidationErrorMessageDialogFragmentandQuestionnaireFragmentto pass in appropriate result messages in callback to change mode from Review to Edit incase there are errors on Submit and user decides to fix them.Alternative(s) considered
No
Type
Choose one: Bug fix
Screenshots (if applicable)
review_mode_edit.webm
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.