-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow developers to add custom search parameter to the engine. #1778
Conversation
@omarismail94 does this have any interaction with your change wrt fhir versions? |
@joiskash hi kashyap - please take a look at this work which might be useful to your implementation. |
Sure @jingtang10 ! Thanks ! |
engine/src/main/java/com/google/android/fhir/FhirEngineProvider.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/FhirEngineProvider.kt
Outdated
Show resolved
Hide resolved
engine/src/main/java/com/google/android/fhir/MoreSearchParameters.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Aditya this is a really good PR 👍
@stevenckngaa + @yigit + @omarismail94 in case you have any more comments. |
…h type reference (#2065) * set the initial value using the initial expression extension for reference type * Allow developers to add custom search parameter to the engine. (#1778) * Added custom search paramter. * Review changes : Injecting ResourceIndexer into ResourceDao * Show submit button in review mode. (#1826) * Show submit button in review mode * Added tests * Review comments: Updated the fragment result listener to check explicit result values * Fix for removing old indexes when resource is updated (#1840) * Fix for removing old indexes when resource is updated * Added comments * add datacapture config in demo app * Fix dropdown initial selection for answerOptions of type Reference Sometimes choiceColumn evaluated to similar 'display' text across many options, and the autocompletetextview text would get set to null * Support expression evaluating to ResourceType for items of type Reference * Update autocompleteTextView to check answerId * Add AutoCompleteViewHolderFactory ui tests * Fix failing tests for AutoCompleteViewHolderFactory * Refactor MoreTypes.kt to remove duplications Co-authored-by: Omar Ismail <[email protected]> * Refactor evaluation of questionnaireItem initial value * Fix AutoCompleteTextViewFactory espresso test failing in api 24 --------- Co-authored-by: omarismail <[email protected]> Co-authored-by: aditya-07 <[email protected]> Co-authored-by: Omar Ismail <[email protected]>
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1382
Description
Alternative(s) considered
No
Type
Choose one: Feature
Screenshots (if applicable)
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.