Remove Engine dependency from SDC. #1742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditya-07
requested review from
deepankarb,
jingtang10,
jjtswan,
joiskash,
kevinmost,
ktarasenko,
omarismail94,
santosh-pingle,
stevenckngaa,
vvikramraj,
wantingzhang77 and
yigit
as code owners
omarismail94
reviewed
Dec 2, 2022
datacapture/src/main/java/com/google/android/fhir/datacapture/DataCaptureConfig.kt
Show resolved
Hide resolved
...capture/src/main/java/com/google/android/fhir/datacapture/MoreQuestionnaireItemComponents.kt
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/DataCaptureConfig.kt
Show resolved
Hide resolved
jingtang10
approved these changes
Dec 14, 2022
datacapture/src/main/java/com/google/android/fhir/datacapture/DataCaptureConfig.kt
Outdated
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/DataCaptureConfig.kt
Show resolved
Hide resolved
...capture/src/main/java/com/google/android/fhir/datacapture/MoreQuestionnaireItemComponents.kt
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireViewModel.kt
Outdated
Show resolved
Hide resolved
datacapture/src/test/java/com/google/android/fhir/datacapture/QuestionnaireViewModelTest.kt
Outdated
Show resolved
Hide resolved
datacapture/src/test/java/com/google/android/fhir/datacapture/QuestionnaireViewModelTest.kt
Show resolved
Hide resolved
kevinmost
pushed a commit
to kevinmost/android-fhir
that referenced
this pull request
Jan 4, 2023
* Added interface to resolve x-fhir-query for library * Review changes * Removed unnecessary imports
LZRS
added a commit
to opensrp/fhircore
that referenced
this pull request
Jan 12, 2023
Due to sdc library decoupling from engine google/android-fhir#1742
LZRS
added a commit
to opensrp/fhircore
that referenced
this pull request
Jan 12, 2023
Due to sdc library decoupling from engine google/android-fhir#1742
LZRS
added a commit
to opensrp/fhircore
that referenced
this pull request
Jan 12, 2023
Due to sdc library decoupling from engine google/android-fhir#1742
LZRS
added a commit
to opensrp/fhircore
that referenced
this pull request
Jan 12, 2023
Due to sdc library decoupling from engine google/android-fhir#1742
sevenreup
pushed a commit
to opensrp/fhircore
that referenced
this pull request
Jan 17, 2023
…1917) * Update to latest 'engine' and 'data-capture' lib versions * Add tests on FhirPlanWorker to improve test coverage * Check for null when sync is of status glitched/failed It seems sometimes sync returns status with the "exceptions" field null, although in kotlin the exceptions field is never expected as null * Update sdc lib to release version 0.1.0-beta06-preview4-SNAPSHOT * Hide submit button for non-paginated questionnaires * Remove margin between progressbar and toolbar for questionnaires * Fix issue with x-fhir-query answer expression failing Due to sdc library decoupling from engine google/android-fhir#1742
pld
pushed a commit
to opensrp/fhircore
that referenced
this pull request
Jan 26, 2023
* Fix issue with x-fhir-query answer expression failing Due to sdc library decoupling from engine google/android-fhir#1742 * Add tests for FhirXFhirQueryResolver * Moving x-fhir query resolver to quest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #1705
Description
Added an interface that Developer Application may provide to resolve x-fhir-query for SDC library.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: Code health
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.