Fix issue with x-fhir-query answer expression failing #1949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1949 +/- ##
============================================
- Coverage 56.27% 56.25% -0.03%
- Complexity 856 857 +1
============================================
Files 215 216 +1
Lines 8155 8158 +3
Branches 1524 1524
============================================
Hits 4589 4589
- Misses 2697 2701 +4
+ Partials 869 868 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Due to sdc library decoupling from engine google/android-fhir#1742
a4ca1e6
to
d5f786e
Compare
ellykits
previously approved these changes
Jan 26, 2023
ellykits
previously requested changes
Jan 26, 2023
| import org.hl7.fhir.r4.model.Resource | ||
|
|
||
| @Singleton | ||
| class FhirXFhirQueryResolver @Inject constructor(val fhirEngine: FhirEngine) : XFhirQueryResolver { |
There was a problem hiding this comment.
Can we move this to the data package in quest application module. Looks like it is only used at the application level. Also rename the class to QuestXFhirQueryResolver
3166573
to
451fa17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the latest release of the sdc library, the app may crash when resolving an x-fhir-query in answer expression
Relates to google/android-fhir#1798 and #1917 (comment)
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #[issue number]
Checklist
strings.xmlfile./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the project's style guide