Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight missing fields and Show validation popup. #1671

Merged
merged 29 commits into from
Dec 4, 2022
Merged

Highlight missing fields and Show validation popup. #1671

merged 29 commits into from
Dec 4, 2022

Conversation

aditya-07
Copy link
Collaborator

@aditya-07 aditya-07 commented Oct 17, 2022 •
edited

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #1576

Description

  1. Made Submit Button VISIBLE by default.
  2. Validate questionnaire response after user clicks Submit button.
  3. Based on the validation result, highlight missing fields and Show missing fields popup.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: Feature

Screenshots (if applicable)

Screenshot_20221128_191146

UPDATED UI

ValuesAsString

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@omarismail94 omarismail94 self-assigned this Oct 18, 2022
omarismail94
omarismail94 reviewed Oct 19, 2022
View reviewed changes
Copy link
Contributor

@omarismail94 omarismail94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aditya-07 took an initial look and left some comments. PTAL and lmk what you think!

...com/google/android/fhir/datacapture/QuestionnaireValidationErrorMessageDialogFragmentTest.kt Outdated Show resolved Hide resolved
...com/google/android/fhir/datacapture/QuestionnaireValidationErrorMessageDialogFragmentTest.kt Show resolved Hide resolved
...com/google/android/fhir/datacapture/QuestionnaireValidationErrorMessageDialogFragmentTest.kt Outdated Show resolved Hide resolved
...com/google/android/fhir/datacapture/QuestionnaireValidationErrorMessageDialogFragmentTest.kt Outdated Show resolved Hide resolved
...com/google/android/fhir/datacapture/QuestionnaireValidationErrorMessageDialogFragmentTest.kt Outdated Show resolved Hide resolved
datacapture/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireViewModel.kt Outdated Show resolved Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/QuestionnaireViewModel.kt Outdated Show resolved Hide resolved
...ava/com/google/android/fhir/datacapture/QuestionnaireValidationErrorMessageDialogFragment.kt Outdated Show resolved Hide resolved
datacapture/src/main/res/layout/questionnaire_validation_error_dialog.xml Outdated Show resolved Hide resolved
@aditya-07 aditya-07 assigned aditya-07 and unassigned omarismail94 Oct 20, 2022
@aditya-07 aditya-07 assigned omarismail94 and unassigned aditya-07 Oct 28, 2022
@aditya-07 aditya-07 removed their assignment Nov 4, 2022
@aditya-07 aditya-07 assigned jingtang10 and unassigned aditya-07 Nov 28, 2022
@jingtang10 jingtang10 assigned aditya-07 and unassigned jingtang10 Nov 29, 2022
@aditya-07 aditya-07 assigned jingtang10 and unassigned aditya-07 Dec 2, 2022
@jingtang10 jingtang10 enabled auto-merge (squash) December 2, 2022 15:39
@jingtang10 jingtang10 merged commit 9f3fc87 into google:master Dec 4, 2022
@aditya-07 aditya-07 deleted the ak/highlight_required_fields branch April 19, 2023 08:29
@jingtang10 jingtang10 mentioned this pull request Feb 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omarismail94 omarismail94 omarismail94 left review comments

@jingtang10 jingtang10 jingtang10 approved these changes

@deepankarb deepankarb Awaiting requested review from deepankarb

@jjtswan jjtswan Awaiting requested review from jjtswan

@joiskash joiskash Awaiting requested review from joiskash

@kevinmost kevinmost Awaiting requested review from kevinmost

@ktarasenko ktarasenko Awaiting requested review from ktarasenko

@santosh-pingle santosh-pingle Awaiting requested review from santosh-pingle

@stevenckngaa stevenckngaa Awaiting requested review from stevenckngaa

@vvikramraj vvikramraj Awaiting requested review from vvikramraj

@wantingzhang77 wantingzhang77 Awaiting requested review from wantingzhang77

@yigit yigit Awaiting requested review from yigit

Assignees

@jingtang10 jingtang10

Labels
None yet
Projects
None yet
Milestone
Data Capture Library 1.0.0
Development

Successfully merging this pull request may close these issues.

Validation: Highlight the required fields when a user submits a form
4 participants
@aditya-07 @jingtang10 @omarismail94 @santosh-pingle