Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows screener survey submission though risk factors form inputs are not answered. #866

Closed
santosh-pingle opened this issue Oct 26, 2021 · 5 comments
Labels
effort:medium Medium effort - 3 to 5 days P2 Medium priority issue type:bug Something isn't working

Comments

@santosh-pingle
Copy link
Collaborator

Describe the bug
As per screener survey questionnaire, it is mandatory to provide input to risk factors questionnaire items.
Though, these questionnaire items are not answered and if user click on Submit button then survey get submitted.

Component
reference app

To Reproduce
Steps to reproduce the behavior:

  1. Open reference app
  2. Click on patient row item, it shows patient details screen
  3. Click on Complete Survey, it shows survey questionnaire form
  4. Do not provide answers on risk factors screen,
  5. Provide input to vital signs.
  6. Click on submit button, it submits the survey.

Expected behavior

If risk factors answers are mandatory as per questionnaire then it need to be answered, if not then it should not allow to submit the survey.
Or
As of now, we are not considering risk factors while assessing patient risk assessment, then in that case we should not make it mandator.

Screenshots
If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

  • Device: Nokia 3.4
  • Android version: [e.g. Settings -> About phone -> Android version]
  • Build number: [e.g. Settings -> About phone -> Build number]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

Would you like to work on the issue?
Please state if this issue should be assigned to you or who you think could help to solve this issue.

@santosh-pingle santosh-pingle added type:bug Something isn't working Triage labels Oct 26, 2021
@santosh-pingle santosh-pingle added this to To do in Demo applications via automation Oct 26, 2021
@Manikant25
Copy link
Contributor

@santosh-pingle Can I take this?

@santosh-pingle
Copy link
Collaborator Author

Just check with @jingtang10 before to start working on it, in case if Jing has any plan.

@jingtang10
Copy link
Collaborator

I don't think we have a clear action plan for this issue.

The problem is that the submit button is entirely in the control of the app developer. So it's really up to the app to decide if they want to accept a questionnaire response even if the validation fails.

so i think this might be working as intended. but we should also explore different validation apis and options.

@Tarun-Bhardwaj Tarun-Bhardwaj added effort:medium Medium effort - 3 to 5 days P2 Medium priority issue Triage and removed Triage labels Jan 6, 2022
@santosh-pingle
Copy link
Collaborator Author

Let me verify whether issue is already fixed?

@jingtang10
Copy link
Collaborator

i think this is now controled by the entry-mode. if it's sequential, you cannot progress to the next page without completing required questions on the current page. but if it's not sequential, you can, and should be able to submit after the popup on the last page. See #1671.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort:medium Medium effort - 3 to 5 days P2 Medium priority issue type:bug Something isn't working
Projects
Status: Complete
Development

No branches or pull requests

4 participants