Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply separate style to question text if type is group. #1546

Merged

Conversation

santosh-pingle
Copy link
Collaborator

@santosh-pingle santosh-pingle commented Aug 8, 2022

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #1450

Description
Earlier, it was okay to have single attribute resource to set style to question text in header view in all views, but now requirement is to set different style to question text if type is group. Therefore we can not keep same existing files and set attribute resource at run time in kolin code according to the group type, as there is no such api which which accepts attribute resource.
So created separate xml resource file for group type header view and updated changes accordingly.

Alternative(s) considered
Another approach is to set attribute resource to question text if type is group in header view in kotlin code, but there is no such api which accept attribute as resource to set the style.

Type
Choose one: Feature
Screenshots (if applicable)
Attaching screenshot for demo purpose only.
@shelaghm
Screen Shot 2022-08-09 at 4 28 55 PM

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@santosh-pingle santosh-pingle marked this pull request as ready for review August 9, 2022 11:11
@santosh-pingle santosh-pingle changed the title Apply style to group type. Apply separate style to question text if type is group. Aug 9, 2022
@santosh-pingle santosh-pingle merged commit b12ff3a into google:master Aug 26, 2022
@Tarun-Bhardwaj Tarun-Bhardwaj added type:bug Something isn't working Data capture labels Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Subtitle text not behaving as expected
3 participants