-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subtitle text not behaving as expected #1450
Comments
@PallaviGanorkar can you take a look at this please |
Case 1: Reproducible in version com.google.android.fhir:data-capture:0.1.0-beta03, but in latest code base its not reproducible, its working fine. |
For Case 2, I did not understand that it was considered subtitle text because the text "Correct!" is rendered the same as the other text on the questionnaire. The intended use would be more clear if the text styling was different. That said, I think it is difficult to understand when something would be considered a subtitle vs a new text element. Can you describe how the rendering logic works based on the JSON structure for documentation purposes? As an alternative, maybe we could use the displayCategory extension to make the rendering style decisions more explicit. |
In addition, the display of "Correct!" does not appear to respect the enableWhen. re: formatting based on JSON structure, the top level text "Demographic Information" looks the same as "Cats are better than dogs". I would expect the contents of a "text" field of a "group" type to be a section header and render differently than a question text. |
i agre with this. maybe we should use display category. maybe we should use "instructions" http:https://hl7.org/fhir/R4/valueset-questionnaire-display-category.html |
@williamito @jingtang10 @santosh-pingle This is a great call out. I agree they should render differently. From what I'm aware of we don't have a "section header" text style. I have some old mocks where we have this type of text rendering above a question. See below |
The "subtitle text" usually instructions that accompany the questions. I think changing it to "instructions" might be the most clear. |
Looking into it. thanks! |
working on it. |
We can provide implementation. thanks! |
looking into it. |
Case 1: The text "Correct!" appears twice, once incorrectly above the question "Cats are better than dogs", and once correctly based on the
enableWhen
element.Case 2: When
enableWhen
is a child of the item, the "Correct!" text never appears. It still shows up incorrectly above the question, like in Case 1.This is using the published version of
com.google.android.fhir:data-capture:0.1.0-beta03
.The text was updated successfully, but these errors were encountered: