Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve failing CI #1119

Merged
merged 5 commits into from
Feb 8, 2022
Merged

resolve failing CI #1119

merged 5 commits into from
Feb 8, 2022

Conversation

epicadk
Copy link
Contributor

@epicadk epicadk commented Feb 6, 2022

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #[issue number]

Description
Clear and concise code change description.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct
  • I have read the Contributing page
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally
  • I have built and run the reference app(s) to verify my change fixes the issue and/or does not break the reference app(s)

@FikriMilano
Copy link
Collaborator

@epicadk In my case, I got an OOM the last time I pushed a code. Works fine locally though

@epicadk
Copy link
Contributor Author

epicadk commented Feb 6, 2022

@epicadk In my case, I got an OOM the last time I pushed a code. Works fine locally though

Yeah what's weird is this time it's failing only on the coverage step (where I increased the ram). Perhaps it's an issue with SqlCipher?

@jingtang10
Copy link
Collaborator

@stevenckngaa not sure if you can shed a light on this.

What i've noticed locally is that if i run the instrumentation tests on my pixel6 everything passes, but if i run it on nokia 4.2 it fails.

so i wonder if this is related to any recent emulator update similar to what happened in ReactiveCircus/android-emulator-runner#160

i am also trying to resolve this in #1118 but haven't gone very far

@jingtang10 jingtang10 linked an issue Feb 6, 2022 that may be closed by this pull request
@jingtang10
Copy link
Collaborator

doesn't look like the change worked :(

@epicadk
Copy link
Contributor Author

epicadk commented Feb 8, 2022

not a ram issue maybe bumping the dependencies might work?

@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #1119 (19157b3) into master (c06c2a3) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1119      +/-   ##
============================================
- Coverage     84.53%   84.52%   -0.01%     
  Complexity      608      608              
============================================
  Files           134      134              
  Lines         10279    10279              
  Branches        756      756              
============================================
- Hits           8689     8688       -1     
- Misses         1214     1215       +1     
  Partials        376      376              
Impacted Files Coverage Δ
...va/com/google/android/fhir/db/impl/DatabaseImpl.kt 88.88% <0.00%> (-1.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c06c2a3...19157b3. Read the comment docs.

@jingtang10
Copy link
Collaborator

Amazing @epicadk

@jingtang10 jingtang10 marked this pull request as ready for review February 8, 2022 08:05
@jingtang10 jingtang10 merged commit 1ff505e into master Feb 8, 2022
@jingtang10 jingtang10 deleted the ak/ci branch February 8, 2022 08:07
@epicadk
Copy link
Contributor Author

epicadk commented Feb 8, 2022

I think @stevenckngaa did something similar before in #1125 😅

@jingtang10
Copy link
Collaborator

Not sure this actually fixed it https://github.com/google/android-fhir/runs/5105727288?check_suite_focus=true

@jingtang10
Copy link
Collaborator

maybe it was a fluke when all the tests passed?

ktarasenko pushed a commit that referenced this pull request Feb 16, 2022
* increase ram size in emulator

* Update ci.yml

* Update ci.yml

* Update ci.yml

* bump versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

EncryptedDatabaseErrorTest Failing
3 participants