Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use macos-latest instead of macos-11 in GitHub Actions #1118

Merged
merged 5 commits into from
Feb 14, 2022
Merged

Conversation

jingtang10
Copy link
Collaborator

@jingtang10 jingtang10 commented Feb 4, 2022

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #1120

Description
Use macos-latest instead of macos-11 in GitHub Actions. This reverses the change in #576.

cc @epicadk

Alternative(s) considered
NA

Type
Choose one: Testing

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct
  • I have read the Contributing page
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally
  • I have built and run the reference app(s) to verify my change fixes the issue and/or does not break the reference app(s)

@jingtang10 jingtang10 mentioned this pull request Feb 6, 2022
7 tasks
@jingtang10 jingtang10 linked an issue Feb 6, 2022 that may be closed by this pull request
@jingtang10 jingtang10 changed the title Update the reactive circus android emulator version to 2.22.0 Try to fix CI Feb 7, 2022
@jingtang10 jingtang10 closed this Feb 8, 2022
@jingtang10 jingtang10 reopened this Feb 8, 2022
@jingtang10 jingtang10 changed the title Try to fix CI Use macos-latest instead of macos-11 in GitHub Actions Feb 8, 2022
@jingtang10 jingtang10 closed this Feb 8, 2022
@jingtang10 jingtang10 reopened this Feb 8, 2022
@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #1118 (23057ad) into master (ce6b01a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1118   +/-   ##
=========================================
  Coverage     84.54%   84.54%           
  Complexity      614      614           
=========================================
  Files           135      135           
  Lines         10299    10299           
  Branches        763      763           
=========================================
  Hits           8707     8707           
  Misses         1212     1212           
  Partials        380      380           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce6b01a...23057ad. Read the comment docs.

@jingtang10 jingtang10 enabled auto-merge (squash) February 8, 2022 18:07
Copy link
Contributor

@epicadk epicadk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Although not sure if we still want this was just for the CI issue. Disabling auto merge for that reason.

@jingtang10
Copy link
Collaborator Author

jingtang10 commented Feb 14, 2022

Not just for the ci issue which has been resolved but i think using the latest image is probably the best practice.

The original fix was meant to be temporary anyway. For that reason I'm gonna merge this.

@jingtang10 jingtang10 merged commit a0647c3 into master Feb 14, 2022
@jingtang10 jingtang10 deleted the jt/ci branch February 14, 2022 09:34
ktarasenko pushed a commit that referenced this pull request Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

EncryptedDatabaseErrorTest Failing
3 participants