Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website: x/vgo, x/lint subrepos are 404 #25048

Closed
dmitshur opened this issue Apr 24, 2018 · 8 comments
Closed

website: x/vgo, x/lint subrepos are 404 #25048

dmitshur opened this issue Apr 24, 2018 · 8 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations)

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Apr 24, 2018

https://golang.org/x/vgo and https://golang.org/x/lint are 404 right now. That means godoc.org can't display their docs, and they can't be fetched with go get, etc.

$ curl https://golang.org/x/vgo
404 page not found
$ curl https://golang.org/x/lint
404 page not found

$ curl -H 'Accept: text/plain' https://godoc.org/golang.org/x/vgo
NOT FOUND
$ curl -H 'Accept: text/plain' https://godoc.org/golang.org/x/lint
NOT FOUND

$ export GOPATH=/tmp/empty
$ go get -d golang.org/x/vgo
package golang.org/x/vgo: unrecognized import path "golang.org/x/vgo" (parse https://golang.org/x/vgo?go-get=1: no go-import meta tags ())
$ go get -d golang.org/x/lint
package golang.org/x/lint: unrecognized import path "golang.org/x/lint" (parse https://golang.org/x/lint?go-get=1: no go-import meta tags ())

They used to work recently. I don't know when exactly they stopped working. The other subrepos are fine.

There are still entries for them at https://github.com/golang/tools/blob/c1def519f03ddf76f16b3e444ee1095d73afa01b/cmd/godoc/x.go#L35 and https://github.com/golang/tools/blob/c1def519f03ddf76f16b3e444ee1095d73afa01b/cmd/godoc/x.go#L50, so I'm guessing it's related to the version of godoc deployed right now.

/cc @andybons @bradfitz

@gopherbot gopherbot modified the milestones: Unreleased, vgo Apr 24, 2018
@dmitshur dmitshur changed the title x/vgo, x/lint: subrepos are 404 website: x/vgo, x/lint subrepos are 404 Apr 24, 2018
@dmitshur dmitshur removed this from the vgo milestone Apr 24, 2018
@bradfitz
Copy link
Contributor

Did the master branch get deployed, then the release branch deployed (reverting the x/link change)?

This needs to be cherry-picked back to release branch probably.

/cc @FiloSottile too.

@bradfitz bradfitz added this to the Unreleased milestone Apr 24, 2018
@bradfitz bradfitz added the NeedsFix The path to resolution is known, but the work has not been done. label Apr 24, 2018
@FiloSottile
Copy link
Contributor

@andybons mentioned while fixing #25022 that he had to fix the deploy scripts to use the release branch, so probably yeah.

@oiooj
Copy link
Member

oiooj commented Apr 24, 2018

Many CI tests which use x/lint failed now.

golang/lint#397

It breaks the world.

kwk added a commit to kwk/fabric8-wit that referenced this issue Apr 24, 2018
kwk added a commit to fabric8-services/fabric8-wit that referenced this issue Apr 24, 2018
joohoi added a commit to joohoi/acme-dns that referenced this issue Apr 24, 2018
joohoi added a commit to joohoi/acme-dns that referenced this issue Apr 24, 2018
@andybons
Copy link
Member

On it.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/109095 mentions this issue: [release-branch.go1.10] cmd/godoc: add x/lint and x/vgo redirects

gopherbot pushed a commit to golang/tools that referenced this issue Apr 24, 2018
Update golang/go#25048

Change-Id: I6e21f167091338600c2a0a37411b0a565d27ce36
Reviewed-on: https://go-review.googlesource.com/96196
Run-TryBot: Andrew Bonventre <[email protected]>
Reviewed-by: Brad Fitzpatrick <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
(cherry picked from commit 733d489)
Reviewed-on: https://go-review.googlesource.com/109095
Reviewed-by: Filippo Valsorda <[email protected]>
@oiooj
Copy link
Member

oiooj commented Apr 24, 2018

The service is normal now. Maybe we need monitor these services.


Sosaras-Air:build sosara$ go get -v golang.org/x/lint
Fetching https://golang.org/x/lint?go-get=1
Parsing meta tags from https://golang.org/x/lint?go-get=1 (status code 200)
get "golang.org/x/lint": found meta tag get.metaImport{Prefix:"golang.org/x/lint", VCS:"git", RepoRoot:"https://go.googlesource.com/lint"} at https://golang.org/x/lint?go-get=1
golang.org/x/lint (download)
golang.org/x/tools/go/ast/astutil
golang.org/x/tools/go/gcimporter15
golang.org/x/tools/go/gcexportdata
golang.org/x/lint

@andybons
Copy link
Member

Fix has been deployed. I apologize for the downtime. Will follow up with monitoring so that we can catch this sooner in the future.

@FiloSottile
Copy link
Contributor

@bradfitz from golang/lint#397 (comment) with context, for anyone curious:

The original lint & vgo redirects were accidentally deployed from the master branch. They were never cherry-picked to the release branch. When golang.org was redeployed later from the release branch (correctly), it effectively reverted the lint redirects.

https://golang.org/cl/109095 does the necessary cherry-pick to the release branch.

joohoi added a commit to joohoi/acme-dns that referenced this issue Apr 25, 2018
joohoi added a commit to joohoi/acme-dns that referenced this issue Apr 25, 2018
Revert "Disable golint until golang/go#25048 is resolved."
@bradfitz bradfitz added the Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) label May 17, 2018
@golang golang locked and limited conversation to collaborators May 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations)
Projects
None yet
Development

No branches or pull requests

6 participants