Skip to content
This repository has been archived by the owner on Mar 11, 2021. It is now read-only.

Commit

Permalink
Temporarily disable golint (#2040)
Browse files Browse the repository at this point in the history
Until golang/go#25048 is resolved.

See also golang/lint#397
  • Loading branch information
kwk committed Apr 24, 2018
1 parent 86ec0f4 commit ac2f733
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 20 deletions.
17 changes: 2 additions & 15 deletions Gopkg.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 5 additions & 4 deletions Gopkg.toml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@


required = [
"github.com/golang/lint/golint",
# "github.com/golang/lint/golint", # TODO(kwk): add back in once https://github.com/golang/go/issues/25048 is resolved
"github.com/fzipp/gocyclo",
"github.com/goadesign/goa/cors",
"github.com/goadesign/goa/encoding/form",
Expand Down Expand Up @@ -101,9 +101,10 @@ ignored = [
name = "k8s.io/client-go"
version = "4.0.0"

[[constraint]]
name = "github.com/golang/lint"
revision = "master"
# TODO(kwk): add back in once https://github.com/golang/go/issues/25048 is resolved
# [[constraint]]
# name = "github.com/golang/lint"
# revision = "master"

[[constraint]]
name = "github.com/fzipp/gocyclo"
Expand Down
3 changes: 2 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,8 @@ release: prebuild-check deps generate build check-go-format analyze-go-code test

.PHONY: analyze-go-code
## Run a complete static code analysis using the following tools: golint, gocyclo and go-vet.
analyze-go-code: golint gocyclo govet
# TODO(kwk): Add golint back in once https://github.com/golang/go/issues/25048 is resolved
analyze-go-code: gocyclo govet

## Run gocyclo analysis over the code.
golint: $(GOLINT_BIN)
Expand Down

0 comments on commit ac2f733

Please sign in to comment.