Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix newly baked lightmap can't override previously baked at same path #94645

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

jsjtxietian
Copy link
Contributor

Fixes #94214

@jcostello
Copy link
Contributor

Finally, I thought it was a problem in my PC

@akien-mga akien-mga merged commit adf5884 into godotengine:master Jul 23, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@jcostello
Copy link
Contributor

jcostello commented Jul 23, 2024

@jsjtxietian I still get this error

image

@jsjtxietian jsjtxietian deleted the lightmap-override branch July 26, 2024 03:24
@jsjtxietian
Copy link
Contributor Author

I tested on master it no longer existed, maybe it's because OS? I'm using win

@jcostello
Copy link
Contributor

I still have this issue in Linux. I test it on several projects and happens only on big scenes

@jsjtxietian
Copy link
Contributor Author

jsjtxietian commented Jul 31, 2024

Interesting, can you upload a MRP somewhere so I can test it ? @jcostello

@jcostello
Copy link
Contributor

@jsjtxietian Debugin the issue I found it has to be with the final texture being greater than the allowed max size. Still the error displayed is the same. We should allow to show more error types @akien-mga

@akien-mga
Copy link
Member

Could you open a new issue for this case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lightmap bake fails when trying to bake for the second time to the same path
3 participants