Restore default clear color after displaying boot splash #94404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Android the boot splash can be shown at a different time, so the clear color restore needs to happen within the `setup_boot_logo` function
m4gr3d
approved these changes
Jul 16, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Android the boot splash can be shown at a different time, so the clear color restore needs to happen within the
setup_boot_logofunctionWhen there is no boot splash logo, we alter the default clear color to
application/boot_splash/bg_color. It needs to be reset after.When there is no environment in the scene, the default clear color is used as the ambient light color. Therefore, in the MRP the entire scene became darker because there was no boot splash logo!
Fixes: #94225
CC @m4gr3d