Remove bone_pose_updated
signal and replace it with the skeleton_updated
signal
#90575
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As has always been the case, the
bone_pose_updated
signal is fired a crazy many times in a single frame and can cause unusual updates in BoneAttachment. It should never be used, but used only by BoneAttachment.For safety and performance, make skeleton fire the
skeleton_updated
signal only once per frame at the moment all modifiers processed. Then, the BoneAttachment uses it.If the user has been using the
bone_pose_updated
signal, replace it with thepose_updated
signal which is used by some Editors. This signal may also be fired multiple times per frame, but is relatively safe to use since it is not fired during the update process although it does not detect changes made by the Modifier.If you need a post modification signal for a specific modifier, use the already existing
SkeletonModifier3d.modifier_processed
signal.For getting the final pose which will be reflected in the skin, use the
skeleton_updated
signal that this PR adds.