Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate scene diff as artifacts for failed regressions #384

Merged

Conversation

Jason0214
Copy link
Collaborator

No description provided.

@Calinou
Copy link
Member

Calinou commented Nov 22, 2020

chunk.io is now said to be invite-only. You'll need to specify a token in the Travis CI secrets if this is merged.

@Jason0214
Copy link
Collaborator Author

Thanks for the notes!

@Calinou
Copy link
Member

Calinou commented Nov 22, 2020

Another service you could use for this is 0x0.st, but its terms of use forbid using it for CI build artifacts. Is the payload you're uploading considered a CI build artifact?

@Jason0214 Jason0214 force-pushed the generate_scene_diff_as_artifacts branch 2 times, most recently from f9d0c98 to d545bae Compare December 6, 2020 09:35
@Jason0214
Copy link
Collaborator Author

@Calinou I found I can get the patch by just parsing the Travis log, so there is no need to use any third-party storage.
Thank you very much for the suggestion.

@rcorre
Copy link
Contributor

rcorre commented Dec 8, 2020

It seems that if you have a version mismatch, travis fails before generating a diff: https://travis-ci.org/github/godotengine/godot-blender-exporter/jobs/748124341#L916

@Jason0214
Copy link
Collaborator Author

@rcorre ah, right. This can not be handled. Mix Blender2.8 and 2.9 scenes would not work in any case.

@Jason0214
Copy link
Collaborator Author

Merge this change as it wouldn't affect the functionality of the CI and possibly could do some good.

@Jason0214 Jason0214 merged commit 0619f24 into godotengine:master Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants