-
-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export Curve objects as Godot Path nodes. #380
Conversation
So I don't forget, we should update https://docs.godotengine.org/en/3.2/getting_started/workflow/assets/escn_exporter/ if/when this merges. |
Fixes godotengine#330. Relates to godotengine/godot-proposals#527. Previously, curves in blender were exported to meshes in Godot. Now, a bezier curve created in blender will be exported as a Path node with a Curve3D resource matching the blender data. The curve will have a child MeshInstance that renders the bevel. Only bezier curves are exported to Godot Path nodes. Other curves, such as Nurbs, export only as meshes as they did previously.
Looks like I need an older blender to set up the reference files. I'll try to get that set up when I can |
Thanks! |
That, or maybe a local |
No, it only offers VMs instead of containers since 2019. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much adding the curve support!
logging.warning("Curve %s has no splines", node.name) | ||
return None | ||
|
||
spline = splines[0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible that we can export all the spline in the node.data.splines
and only assign the active one to the Curve node? How do you think? (Btw you can get the active spline by calling node.data.splines.active
)
I found it is possible to generate a scene diff patch from the Travis log, I did it in #384. I found the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's blocked by a mismatch between the Blender version of test scene (Blender 2.9) and the Blender version that CI runs.
How about removing the test scene temporarily from this change to get it submitted first?
And then bump the Blender version in CI and handle the out-dated test scenes in another change. I can not think of any better ways to do it : (
They are generated with too recent of a blender version. We'll add them again after bumping the blender CI version.
Fixes #330.
Relates to godotengine/godot-proposals#527.
Previously, curves in blender were exported to meshes in Godot.
Now, a bezier curve created in blender will be exported as a Path node
with a Curve3D resource matching the blender data. The curve will have a
child MeshInstance that renders the bevel.
Only bezier curves are exported to Godot Path nodes. Other curves, such
as Nurbs, export only as meshes as they did previously.