feat: build pipeline visualizer #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0a15600.
|
see the fix, thank you! only feedback i have is that i sort of expected the whole container/stage to get marked as failed as it happens in your video from the description: in my case it stayed green even though one of the steps error'd and caused the build to fail. i think the only scenario i can see where the whole container/stage should still be green is if they had ruleset: continue: true in there on the steps that failed? (i didn't do much testing on that yet) |
|
sure I'll check out that scenario. that logic is controlled by the BuildGraph endpoint so the best we can do is tweak the OverallStageStatus function in the server code to be better at determining "stage status" and then the UI will just reflect whatever it returns |
wass3r
previously requested changes
Nov 2, 2023
wass3rw3rk
previously approved these changes
Nov 2, 2023
Comment on lines
+103
to
+127
| export type GraphData = { | ||
| /** @property dot: string */ | ||
| dot: string; | ||
| /** @property buildID: number */ | ||
| buildID: number; | ||
| /** @property filter: string */ | ||
| filter: string; | ||
| /** @property focusedNode: number */ | ||
| focusedNode: number; | ||
| /** @property showServices: boolean */ | ||
| showServices: boolean; | ||
| /** @property showSteps: boolean */ | ||
| showSteps: boolean; | ||
| /** @property centerOnDraw: boolean */ | ||
| centerOnDraw: boolean; | ||
| }; | ||
|
|
||
| export type GraphInteraction = { | ||
| /** @property eventType: string */ | ||
| eventType: string; | ||
| /** @property href: string */ | ||
| href: string; | ||
| /** @property nodeID: string */ | ||
| nodeID: string; | ||
| }; |
wass3rw3rk
previously approved these changes
Nov 2, 2023
wass3rw3rk
approved these changes
Nov 3, 2023
ecrupper
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires server changes from go-vela/server#995
closes go-vela/community#71
org/repo/1/graphfor build tab titledVisualizethe code added will retrieve a graph object from the server, generate a DOT string in Elm, generate the html using Graphviz, then bootstrap style and interactivity using d3 and scss.
inspiration was taken from the d3-graphviz by https://github.com/magjac and various CI tools.
Demo
build-viz-final.mov
Light Theme
needs some work, but so does the rest of light theme.