Fix bug when add new bookmark using PostgreSQL #480
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @fukajun, thank you for finding this bug! While the solution is not optimal, the actual implementation is not very good as well, so I'm good with merging this into Shiori, but could you add some tests so we have some workflows covered? I have plans to refactor this in the future so we don't need to get a new ID from the database (we will either generate ir ourselves or insert the bookmark before creating archives). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug pages not archived although createArchive checkbox checked. (fix: #385)
Maybe it is only occurred using postgres.
To be precise, the archive is saved, but the ID to refer to different.
This ploblem reason is diffrent create file path id(archive and thumb) and create bookmark record id.
Function of CreatNewID return recently numbered bookmark id that is not same to be insert bookmark record id.
Returned bookmark id is used to path of save thumb and archive.
But, record inserted by next numbered id.
As a result, New bookmark record try to refered not exists directory pathes.
This fix will be changes CreateNewID returned to be next numbered bookmark record id.
Excuse, This implements is not think about concurrency bookmarking.
But, Current implement is same about this point.