Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a URL doesn't automatically create an archive #385

Closed
thelazyoxymoron opened this issue Feb 25, 2022 · 6 comments
Closed

Adding a URL doesn't automatically create an archive #385

thelazyoxymoron opened this issue Feb 25, 2022 · 6 comments
Labels
component:backend database:postgres priority:high tag:more-info More information needed type:bug Something isn't working

Comments

@thelazyoxymoron
Copy link

I have turned on the "Create archive by default" setting and I see the relevant option ticked as well when I'm adding a new URL. However, it doesn't actually create an archive, I have to manually go and do update archive.
@Grauwolf
Copy link

when using SQLite it seems to work as intended. when configuring a PostgreSQL database, I can confirm that no archive is created, even though "create archive" is enabled.

@fmartingr
Copy link
Member

I have turned on the "Create archive by default" setting and I see the relevant option ticked as well when I'm adding a new URL. However, it doesn't actually create an archive, I have to manually go and do update archive.

Is this happening to you in postgresql as well?

@fmartingr fmartingr added component:backend database type:bug Something isn't working tag:more-info More information needed labels Feb 26, 2022
@MidnightSnowleopard
Copy link

I can confirm I am seeing the same behavior with PostgreSQL. Haven't test for SQLite but the behavior is present on Shiori 1.5.2 and 1.5.2 in docker.

@thelazyoxymoron
Copy link
Author

Is this happening to you in postgresql as well?

Sorry, should've mentioned this, I'm using Postgresql, haven't tried with SQLite.

ogumaru added a commit to ogumaru/shiori that referenced this issue Apr 6, 2022
@ogumaru
fix: Adding a URL doesn't automatically create an archive (go-shiori#385
45f60c6 
)

Fixed a bug pages not archived although createArchive checkbox checked.
ogumaru added a commit to ogumaru/shiori that referenced this issue Apr 6, 2022
@ogumaru
fix: Adding a URL doesn't automatically create an archive (go-shiori#385
13b15f5 
)

Fixed a bug pages not archived although createArchive checkbox checked.
@ogumaru ogumaru mentioned this issue Apr 6, 2022
Closed
@fukajun fukajun mentioned this issue Sep 28, 2022
Closed
@fukajun
Copy link

fukajun commented Sep 29, 2022

Maybe I fixed it. Please review PR #480.

@fmartingr fmartingr mentioned this issue Oct 7, 2022
Merged
@fmartingr
Copy link
Member

Apparently fixed in #484, please open a new issue if you experience something similar again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:backend database:postgres priority:high tag:more-info More information needed type:bug Something isn't working
Projects
None yet
Milestone
No milestone
5 participants
@Grauwolf @fukajun @fmartingr @MidnightSnowleopard @thelazyoxymoron